LibRegex: Cache 1 MiB worth of bytecode for each parser #1828
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a convenience shortcut for *take(begin()->key).
alimpfard
force-pushed
the
regex-cache
branch
from
87a556a
to
aafadc9
Compare
|
CI says ASAN no likey |
|
Huh. Will take a look. |
While LibJS does cache regex literals, there's more than one way to create regex objects, this cache is hit regularly just browsing the web, though no real measurement has been done on its potential speedups.
alimpfard
force-pushed
the
regex-cache
branch
from
aafadc9
to
d11000c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While LibJS does cache regex literals, there's more than one way to
create regex objects, this cache is hit regularly just browsing the web,
though no real measurement has been done on its potential speedups.