LibWeb: Initial steps towards implementing NavigationActivation #1808
+159
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
commented
Oct 15, 2024
| && previous_entry_for_activation.value()->document_state()->origin() == origin() | ||
| && !previous_entry_for_activation.value()->document()->is_initial_about_blank()) { | ||
| && previous_entry_for_activation->document_state()->origin() == origin() | ||
| && !previous_entry_for_activation->document()->is_initial_about_blank()) { |
There was a problem hiding this comment.
The crash I mention is on this line due to a null document - still trying to figure out how this is meant to be set, or why it is getting set to null
shannonbooth
force-pushed
the
navigation-activation-impl
branch
from
2c7c13d
to
975e972
Compare
rmg-x
reviewed
Oct 19, 2024
| @@ -4,6 +4,7 @@ | |||
| * Copyright (c) 2021-2023, Luke Wilde <[email protected]> | |||
| * Copyright (c) 2021-2024, Sam Atkins <[email protected]> | |||
| * Copyright (c) 2024, Matthew Olsson <[email protected]> | |||
| * Copyright (c) 2023-2024, Shannon Booth <[email protected]> | |||
There was a problem hiding this comment.
I think the email is incorrect :^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the bulk of the implementation prepared for NavigationActivation. Unfortunately, it isn't working fully at this stage due to what appear to be spec bugs - and also some of our own!
The first issue is a simple editorial one whatwg/html#10703 - which I saw now after seeing that wehave not been passing through "displayedEntry" to "update_for_history_step_application":
ladybird/Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
Line 756 in 7a92b47
Unfortunately, even after doing a local patch for that, we then run into a crash due to document() being null on the "previousEntry" inside of "update_for_history_step_application", which I am still trying to figure out. It is maybe possible the issue is related to whatwg/html#9869 - it could also simply be a bug in our code somewhere - but my understanding is still very much lacking in this area to have narrowed this down at all. Ideas appreciated for what might be going wrong!