Add AnyEncryptioKey trait
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurges
reviewed
Sep 21, 2023
maurges
reviewed
Sep 21, 2023
|
I also don't like the trait name rn, but we've already set the precedent with similarily named traits (and it might have been me who started it in cggmp :/) |
|
The naming sounds fine to me. If you have suggestions, feel free to share them. |
maurges
approved these changes
Sep 21, 2023
|
Maybe something like IsEncryptionKey would be better? Not going to die on either hill |
|
It sounds more like a question, I'd guess this trait is for testing whether something is encryption key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.