probes unhealthy only if threshold exeeded #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maskym Vavilov <[email protected]>
This was
linked to
issues
Nov 25, 2024
maleck13
reviewed
Nov 25, 2024
| }) | ||
| unhealthyAddresses = append(unhealthyAddresses, probe.Spec.Address) | ||
| } | ||
| // if unhealthy or we haven't probed yet |
There was a problem hiding this comment.
ok good so assume not healthy until proven is
There was a problem hiding this comment.
yes. Unless heathy: true we consider it unhealthy
maleck13
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure we mark probes as unhealthy only when consecutive failures exceed the threshold. Before we would mark it as unhealthy and refuse update the record until threshold exceeded.
This leads to a situation when the premature reconciliation on the health status change will be triggered but result in to changes and will fall back to a default validation time.