-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with KGP 2.1.0-RC #3898
base: compiler-2.1.0
Are you sure you want to change the base?
Test with KGP 2.1.0-RC #3898
Conversation
f05c18c
to
59d2ab3
Compare
DGPv2 uses kotlinx.serialization for encoding the parameters for the HTML and Versioning Dokka plugins, but yes, I agree it could be removed. It'd help keep the buildscripts cleaner. |
I've extracted removing compiler plugin into separate PR (#3899). |
|
compilation is failing with:
Probably there is some issue with kotlinx.serialization compiler plugin usage when using
kotlin.compiler.runViaBuildToolsApi
.KGP version = 2.1.0-RC-330
Kotlin compiler version used to compile code = 2.0.20
I've tried to set all different versions of kotlinx.serialization plugins, but none of them work.
Not sure where the issue comes from, but probably the easiest way will be to drop
kotlinx.serialization
usage from DGPv2 so that there will be less moving parts :)It's possible to replace it:
kotlinx.serialization
usage viaJsonObject
kotlinx.serialization
can be fully dropped as it's used only for single class which could be easily replaced with just a txt file with 4 lines :)Note: last commit adds a workaround: d43e162
with applied workaround, there are several failed DGPv2 functional tests