-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several style improvements #3745
base: master
Are you sure you want to change the base?
Conversation
- Add more minimalist scrollbar for webkit with fallback for firefox. - Add purple highlight to sidebar, section tabs, and more, in dark mode for parity with light mode. - Massively improve quote block styling. - Change contrast of block quotes. - Add transition effect for section tab hover/select. - Remove codeblock overflow. - Increase sidebar width, add logic to prevent sidebar from being too large on smaller screens. Signed-off-by: solonovamax <[email protected]>
Hey, thanks for the PR! |
most of these are really minor changes for things, but if there's a branch for the new documentation format I could take a peek at it and port it to there if you'd like |
also, smth that could possibly be considered would be adding a compile step for scss -> css then using that css in the output. this would make it a tad bit nicer to write & organize css for dokka. I have smth similar set up in this repo, just using freefair's sass gradle plugin to compile it. with scss I can
though if the UI is being majorly reworked, the vast majority of the UI could be moved into its own subproject so that way it gets a compile step allowing for things like cssnano, etc. to minify it. |
hey, any updates on this? I'd love to see this merged, and if there is anything that needs discussing, I'd be more than happy to pop in to slack (or elsewhere) to do so. |
Hey, let's check what could be contributed after the Dokka 2.0.0 release with HTML changes. Here is a sneak peek for the amount of changes |
I'll clone that branch and see which changes still apply, which need to be changed, and possibly if there are any new ones to add. Then, I'll rebase my branch against that branch, to pull in those changes. |
This PR adds several improvements to the style.
You can see what most of the changes look like here, however a few have been updated/have had minor changes to them since I made that plugin.