Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(View): Fix showOrientationAxes error #91

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

tamaynard
Copy link
Contributor

Following up on #78

@tamaynard tamaynard changed the title fix(View): Implement suggested fix by @floryst fix(View): Fix showOrientationAxes error Dec 12, 2022
@sankhesh
Copy link
Contributor

@tamaynard Could you please add a better commit message describing the change and what issue it fixes?

@tamaynard tamaynard force-pushed the fix-orientation-axes branch 2 times, most recently from 16e758c to 460c3bd Compare December 16, 2022 15:51
@tamaynard tamaynard force-pushed the fix-orientation-axes branch from 460c3bd to cb10ab3 Compare December 16, 2022 15:56
@tamaynard
Copy link
Contributor Author

I added an updated message, plus re-added the line adding the newly constructed renderer to renderwindow

@floryst
Copy link
Collaborator

floryst commented Dec 19, 2022

LGTM!

@floryst floryst merged commit 0bd5eea into Kitware:master Dec 19, 2022
github-actions bot pushed a commit that referenced this pull request Dec 19, 2022
fix(View): Fix showOrientationAxes error 0bd5eea
@jourdain
Copy link
Collaborator

🎉 This PR is included in version 1.15.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants