Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for validation of XML submission files #2437

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add support for validation of XML submission files #2437

wants to merge 5 commits into from

Commits on Nov 25, 2024

  1. add XML validation to all submissions

    @sbelsk @josephsnyder
    sbelsk authored and josephsnyder committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    cf73d7d View commit details
    Browse the repository at this point in the history

  2. hide submission validation behind a feature flag

    @sbelsk @josephsnyder
    sbelsk authored and josephsnyder committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6c1ad03 View commit details
    Browse the repository at this point in the history

  3. add unit test for xml submission file validation

    @sbelsk @josephsnyder
    sbelsk authored and josephsnyder committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    84b56c3 View commit details
    Browse the repository at this point in the history

  4. Use storage_path on ctest submit for validation 

    When attempting to validate an HTTP submission use the `storage_path` helper
to turn the filename which starts at the inproess folder, `inprocess/<>.xml`,
to a full path.  This should not affect the path given directly to the
submission:validate artisan command.
    @josephsnyder
    josephsnyder committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    858edce View commit details
    Browse the repository at this point in the history

  5. Switch to submission time validation of XML files 

    Add a test which utilizes the submission function of KWTester to
submit the same data as the manual validation steps.
    @josephsnyder
    josephsnyder committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    309f06e View commit details
    Browse the repository at this point in the history