Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC code redo #1738

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

anakaren-rojas
Copy link
Contributor

@anakaren-rojas anakaren-rojas commented Oct 9, 2024

Summary:

Redo of POC code for ZND

Issue: LEMS-2272

Test plan:

@anakaren-rojas anakaren-rojas self-assigned this Oct 9, 2024
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 9, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/tidy-suns-wait.md, packages/math-input/src/types.ts, packages/perseus/src/perseus-types.ts, packages/perseus/src/components/math-input.tsx, packages/perseus-editor/src/widgets/expression-editor.tsx, packages/math-input/src/components/keypad/keypad.tsx, packages/math-input/src/components/keypad/mobile-keypad-internals.tsx, packages/math-input/src/components/keypad/shared-keys.tsx, packages/perseus/src/components/__tests__/math-input.test.tsx, packages/perseus/src/widgets/expression/expression.test.tsx, packages/perseus/src/widgets/expression/expression.tsx, packages/perseus-editor/src/widgets/__tests__/expression-editor.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team October 9, 2024 23:40
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Size Change: +67 B (+0.01%)

Total Size: 1.29 MB

Filename Size Change
packages/math-input/dist/es/index.js 77.9 kB +46 B (+0.06%)
packages/perseus-editor/dist/es/index.js 697 kB +8 B (0%)
packages/perseus/dist/es/index.js 425 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.7 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Oct 9, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (ad48ffd) and published it to npm. You
can install it using the tag PR1738.

Example:

yarn add @khanacademy/perseus@PR1738

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1738

@benchristel
Copy link
Member

@anakaren-rojas is this PR still needed? If not, can you close it? :)

@anakaren-rojas
Copy link
Contributor Author

@benchristel yes, ill create a znd for it this week and then close it out

@anakaren-rojas anakaren-rojas removed the request for review from a team November 7, 2024 20:51
@anakaren-rojas
Copy link
Contributor Author

anakaren-rojas commented Nov 18, 2024

Waiting on playtest and content approval before landing or closing

@khan-actions-bot khan-actions-bot requested a review from a team December 4, 2024 00:12
@anakaren-rojas anakaren-rojas removed the request for review from a team December 4, 2024 00:20
@khan-actions-bot khan-actions-bot requested a review from a team December 4, 2024 17:39
@anakaren-rojas
Copy link
Contributor Author

Will have a playtest next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants