Change the defaults of ka-clone and reorder things slightly #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I also added some "opposite" args in arg groups (e.g.,
--protect-master
and--no-protect-master
), which users can't use at the same time.So, the defaults are now (currently):
@csilvers are these defaults good? Do you think I should toggle any of them? This is what I landed on after I started the implementation.
Should I rename these args to be a little more consistent with each other and their function? I don't love how they currently are (e.g.,
--no-msg
meaning "don't use the ka commit template" and--no-lint
referring to the pre-push linter but not the commit-msg linter), but don't know who else may have hard-coded them as they currently are. (Or if it's worth doing.)Issue: FEI-6001
Test plan:
ka-clone
with no args, sees that the defaults are what we are saying they are--protect-master
and--no-protect-master
), and see that it errors