Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mirror and reverse feature, updated readme.md and fix some whitespaces #23

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nonepork
Copy link

@nonepork nonepork commented Feb 4, 2024

I'm not sure whether I got the version right or not. Also I don't know is this the right way to upload images :p

@nonepork nonepork mentioned this pull request Feb 4, 2024
4 tasks
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces new features to the VividHues package, specifically adding 'mirror' and 'reverse' methods to the Clr class, which manipulate strings to display them in mirrored or reversed and mirrored formats. Additionally, the PR includes updates to the README.md to document these new features and makes minor whitespace adjustments in the code.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the new 'mirror' and 'reverse' methods handle edge cases such as characters not present in the 'MIRROR_DICT' and uppercase letters.
  • Correct the image URLs in the README.md to point to the correct repository path to prevent broken links.
  • Consider updating the PR description to provide more clarity on the changes made and confirm the version number is correct as per the project's versioning scheme.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

VividHues/__init__.py Show resolved Hide resolved
VividHues/__init__.py Show resolved Hide resolved
@@ -283,6 +283,28 @@ Clr.delPrevLine(5)
> ```
> ###### Paint your letters in a repeating pattern, by specifying an unlimited amount of Clr codes!

<br />

#### :mirror: Clr.mirror()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (llm): The image URLs in the README for the mirror and reverse methods seem to have a typo in the repository path ('nonepork' instead of 'KennyOliver'). This will lead to broken image links in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant