Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RedisSharedClient that can share one connected driver for more clients #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add RedisSharedClient that can share one connected driver for more clients #49

wants to merge 3 commits into from

Conversation

forrest79
Copy link
Contributor

Proof of concept yet...

  • new RedisSharedClient based on RedisClient, but share one driver for many connections
  • I am not sure with names (obviously), I made ConnectionPool, but it is pool of drivers... For me connection better describes what it is, but it could be confusing because it is drivers...
  • I don't make DI config yet, I have no idea, what config can be set to use RedisSharedClient instead of RedisClient
  • disadvantage: if user get driver with getDriver() method, than user have to expected, that some RedisSharedClient can change database...

fprochazka
fprochazka reviewed Jun 5, 2015
View reviewed changes
src/Kdyby/Redis/ConnectionPool.php


/**
* @author Filip Procházka <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be your name ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He, yes, thanks :-)

@forrest79
Copy link
Contributor Author

When you will have a minute, can you take a look at last notes? :-) Thanks

@fprochazka
Copy link
Member

I like it :) I just need to look at the code more thoroughly and then we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forrest79 @fprochazka