Skip install step when metadata is unchanged #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: 1 hr 13 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
KSP-CKAN/NetKAN#10308 is changing 177 netkans in a way that should have no impact on their inflated metadata (with a few exceptions where
x_via: Automated SpaceDock CKAN submissionis being removed). This took over an hour to validate, partly because it ran the full validation for every mod, including installing it and its dependencies.When a .ckan file exactly matches what we already have for that mod release in the metadata repo, it will install the same as before. We have a
diffstep already, but we simply print it regardless of what it is and then proceed to the install.Changes
Now if a diff is empty, we announce it and skip the install step. This will make no-op netkan changes validate more quickly.