Enlarge cache based on disk size #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techman83
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
KSP-CKAN/NetKAN#10129 took 1h 50m to validate, because for each of the 19 files it validated, it re-downloaded 3 GiB of mod files.
Cause
If you go through the logs of the various installation test steps in detail, some mods do show up as
(cached), but others don't, and different ones are cached in each step. This is consistent with overflowing the limit and having the oldest downloads purged after installation.The limit is currently 5000 MiB, but the GitHub runners are documented to have a capacity of 14 GiB currently.
Changes
Now we set the limit to the free space plus the current size of the cache minus one gigabyte. This should allow more downloads to accumulate before they get purged, up to closer to the size of the container.