Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stability tolerance based on installing module #100

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

HebaruSan
Copy link
Member

Problem

In KSP-CKAN/NetKAN#10325, two modules with prereleases are being updated, but validation is failing because it is installing the prerelease of one module alongside the regular release of the other, which causes file overwrites:

  File           : GameData/StarshipExpansionProject/Props/StarshipMFD/MainScreenAttitudeBlankSPDMODE.png
  Installing Mod : StarshipExpansionProjectIVA v.3.0.0-b2
  Owning Mod     : StarshipExpansionProject v.2.2.0 (installed 12/11/2024 02:07:16, auto-installed)
  CKAN Version   : v1.35.3+24345

In typical usage this would not happen because the overall prerelease setting would determine for both mods whether prereleases are available.
(A user who chooses to enable prereleases for just one of these two mods will have to learn to make better choices.)

Changes

Now when we install a mod, if it's a prerelease, then we enable all prereleases in the dummy instance. This will allow prereleases to be pulled in as dependencies when installing other prereleases.

@HebaruSan HebaruSan merged commit 258af56 into KSP-CKAN:master Dec 11, 2024
2 checks passed
@HebaruSan HebaruSan deleted the feature/pre-releases branch December 11, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant