Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute entrypoint path to run as Action #351

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Absolute entrypoint path to run as Action #351

merged 1 commit into from
Nov 25, 2024

Conversation

HebaruSan
Copy link
Member

Motivation

I'm trying to use the kspckan/netkan container in a GitHub Action, see KSP-CKAN/CKAN#4265 for details.

GitHub's docker command uses --workdir /github/workspace to override the container's WORKDIR. This breaks our ENTRYPOINT because it uses a relative path.

Changes

Now the ENTRYPOINT contains the full absolute path.

@HebaruSan HebaruSan added the Enhancement New feature or request label Nov 25, 2024
@HebaruSan HebaruSan merged commit 7df6fd6 into KSP-CKAN:master Nov 25, 2024
3 checks passed
@HebaruSan HebaruSan deleted the fix/docker-abs-path branch November 25, 2024 03:22
@HebaruSan
Copy link
Member Author

A few more wrinkles to iron out, apparently.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HebaruSan