Fix deprecations

[femtocleaner]

I fixed a number of deprecations for you

[ararslan]

Not a fault of the bot, but the comment above that explicitly says that @recipe doesn't yet support where, so this change isn't valid.

[iblislin]

JuliaPlots/RecipesBase.jl#22
master of RecipesBase already supported it.

[ararslan]

There hasn't been a tag of RecipesBase that includes the change though. When that happens we can make the where change here and bump the minimum version of RecipesBase in REQUIRE to the version that correctly handles where.

Though that brings me to a general gripe of mine with this package: It shouldn't depend on a piece of one particular plotting stack. It would be better to separate the plotting of time series out of this package, though I'm not sure how best to do that. That's an aside though.

[iblislin]

There hasn't been a tag of RecipesBase that includes the change though. When that happens we can make the where change here and bump the minimum version of RecipesBase in REQUIRE to the version that correctly handles where.

I'm waiting it for being widely tested.
JuliaPlots/RecipesBase.jl#23 (comment)

Though that brings me to a general gripe of mine with this package: It shouldn't depend on a piece of one particular plotting stack. It would be better to separate the plotting of time series out of this package, though I'm not sure how best to do that. That's an aside though.

IMO, I prefer a single, versatile repo.
I also think RecipesBase.jl is quite stable. I'm fine with depending on it.

TimeSeries.jl/REQUIRE

Line 2 in 377985e

RecipesBase

[ararslan]

My problem with depending on a particular piece of one plotting stack is that it makes it easy to plot with that stack but not with others. As an example, RecipesBase is exclusive to Plots.jl and its ecosystem, but I plot almost exclusively in Gadfly. I don't doubt that RecipesBase is stable, it seems unfair for a more general package to be opinionated about how you should plot things. But maybe that's just me.

[iblislin]

I'm sorry for letting you feel uncomfortable about Plots.jl only in current state.
Merging something from TimeSeriesTools.jl is in my personal overflowed todo stack...
e.g. https://github.com/GordStephen/TimeSeriesTools.jl/blob/master/src/visualizations.jl

What I want is managing to embrace more ecosystems if possible! And I want all of them are gathered in the same repo instead of spilling features into lots of repos; we can do well integration testing/upgrading.
so... i'm curious about that optional dependency is possiable or not, something like try: import ... in Python. That will allow us to build something like a plugin system. User just choose the ecosystem they like, plug and play.

[ararslan]

Optional dependencies are definitely the way to go here (and elsewhere), the problem is that there's no direct support for them in Julia yet. 🙁