-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include non-convex polygon struct VPolygonNC
✳️
#3116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had an initial look.
Co-authored-by: Marcelo Forets <[email protected]>
VPolygonNC
🔳
VPolygonNC
🔳VPolygonNC
✳️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there should be a note about the order of the vertices in the documentation. For now we can allow both CW and CCW until we have a reason to choose, but you can also decide for one already.
Apart from that the PR looks good, thanks!
(@mforets can approve the build once ready.)
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
In this repo the docs job fails if there are missing docstrings. Please create a new file |
Done |
The docs job passed but there are some doctests which error >> https://github.com/JuliaReach/LazySets.jl/actions/runs/3233891985/jobs/5296713250#step:6:1206 |
At least locally it is solved: Test Summary: | Pass Total Time
LazySets.doctests | 1 1 50.5s
50.463812 seconds (77.29 M allocations: 5.399 GiB, 4.06% gc time, 58.11% compilation time: 1% of which was recompilation)
Testing LazySets tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passing!
I have a few minor requests listed below, but we can make a new issue to address them.
- Add a function
vertices_list
similar to this one - Add a function
tovrep
similar to this one - Add a function
an_element
similar to this one - Add functions translate / translate!
- Define isoperationtype
- Define the function
dim
, example here - Define
isconvextype
, example here
See #3124 |
Thanks again for your contribution @mvanzulli! We just published a new release and I added your name to the release log. Let me know if you do not want to appear there. |
The polygon interface aim to consider geometric figures like non-convex polygons in 2D in order to further on implement Jaccard and Haussdorf similarity numbers.
addressing #3115