Merge pull request #3553 from JuliaReach/schillic/box_approximation

Disallow `box_approximation` for unbounded sets
JuliaReach · Sep 7, 2024 · a6f15cd · a6f15cd
2 parents 853a9aa + 8a3af7d
commit a6f15cd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Approximations/box_approximation.jl b/src/Approximations/box_approximation.jl
@@ -54,6 +54,9 @@ function box_approximation(S::LazySet{N}) where {N}
     r = Vector{N}(undef, n)
     @inbounds for i in 1:n
         lo, hi = extrema(S, i)
+        if isinf(lo) || isinf(hi)
+            throw(ArgumentError("the box approximation of an unbounded set is undefined"))
+        end
         ri = (hi - lo) / 2
         if ri < zero(N)
             if !_geq(ri, zero(N))

diff --git a/test/Sets/Line.jl b/test/Sets/Line.jl
@@ -46,6 +46,9 @@ for N in [Float64, Rational{Int}, Float32]
     # boundedness
     @test !isbounded(l1)
 
+    # box_approximation
+    @test_throws ArgumentError box_approximation(l1)
+
     # ispolyhedral
     @test ispolyhedral(l1)