Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure marker, line, fill, error attributes #4489

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

BeastyBlacksmith
Copy link
Member

@BeastyBlacksmith BeastyBlacksmith commented Nov 1, 2022

I just wanted to implement the "more attributes" solution to #4476 and then one theng came to the other...

This is very early stage. It will reorganize the mentioned attributes to use the @add_attributes macro and therefore lots of internal names change (I apologize in advance, since this will break someones tests quite likely)

It is also planned to go from just fill to x/y/zfill which will solve a remaining issue from #4164

More info will follow once this progresses some more.

TODO

  • let @add_attributes create keyword constructor
  • visit documentation creation
  • finish marker
  • finish line
  • finish error
  • rename fill -> yfill
  • alias fill -> yfill
  • check magic arguments

Comment on lines +2126 to 2132
plotattributes[:marker_stroke_color] = if plotattributes[:marker_stroke_color] === :match
plot_color(sp[:foreground_color_subplot])
elseif plotattributes[:markerstrokecolor] === :auto
get_series_color(plotattributes[:markercolor], sp, plotIndex, stype)
elseif plotattributes[:marker_stroke_color] === :auto
get_series_color(plotattributes[:marker_color], sp, plotIndex, stype)
else
get_series_color(plotattributes[:markerstrokecolor], sp, plotIndex, stype)
get_series_color(plotattributes[:marker_stroke_color], sp, plotIndex, stype)
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
plotattributes[:marker_stroke_color] = if plotattributes[:marker_stroke_color] === :match
plot_color(sp[:foreground_color_subplot])
elseif plotattributes[:markerstrokecolor] === :auto
get_series_color(plotattributes[:markercolor], sp, plotIndex, stype)
elseif plotattributes[:marker_stroke_color] === :auto
get_series_color(plotattributes[:marker_color], sp, plotIndex, stype)
else
get_series_color(plotattributes[:markerstrokecolor], sp, plotIndex, stype)
get_series_color(plotattributes[:marker_stroke_color], sp, plotIndex, stype)
end
plotattributes[:marker_stroke_color] =
if plotattributes[:marker_stroke_color] === :match
plot_color(sp[:foreground_color_subplot])
elseif plotattributes[:marker_stroke_color] === :auto
get_series_color(plotattributes[:marker_color], sp, plotIndex, stype)
else
get_series_color(plotattributes[:marker_stroke_color], sp, plotIndex, stype)
end

cstr, a = pgf_color(
plot_color(get_markercolor(plotattributes, i), get_markeralpha(plotattributes, i)),
plot_color(get_marker_color(plotattributes, i), get_marker_alpha(plotattributes, i)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
plot_color(get_marker_color(plotattributes, i), get_marker_alpha(plotattributes, i)),
plot_color(
get_marker_color(plotattributes, i),
get_marker_alpha(plotattributes, i),
),

@@ -1788,14 +1788,14 @@ end
function gr_draw_contour(series, x, y, z, clims)
GR.setprojectiontype(0)
GR.setspace(clims[1], clims[2], 0, 90)
gr_set_line(get_linewidth(series), get_linestyle(series), get_linecolor(series), series)
gr_set_line(get_linewidth(series), get_linestyle(series), get_line_color(series), series)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
gr_set_line(get_linewidth(series), get_linestyle(series), get_line_color(series), series)
gr_set_line(
get_linewidth(series),
get_linestyle(series),
get_line_color(series),
series,
)

@add_attributes series struct XErrorBar
color = :match
shape = :hline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmarks:
    • Target: 1 Nov 2022 - 17:43
    • Baseline: 1 Nov 2022 - 17:44
  • Package commits:
    • Target: 42b5a1
    • Baseline: f178ae
  • Julia commits:
    • Target: 36034a
    • Baseline: 36034a
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["display"] 0.00 (5%) ✅ 0.00 (1%) ✅
["load"] 1.02 (5%) 1.06 (1%) ❌
["load_plot_display"] 0.96 (5%) 0.00 (1%) ✅
["plot"] 0.77 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1441 s          2 s        232 s       2625 s          0 s
       #2  2593 MHz       1555 s          1 s        214 s       2531 s          0 s
  Memory: 6.78125 GB (5322.0859375 MB free)
  Uptime: 436.26 sec
  Load Avg:  1.04  0.83  0.39
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       2075 s          2 s        252 s       2866 s          0 s
       #2  2593 MHz       1793 s          1 s        222 s       3177 s          0 s
  Memory: 6.78125 GB (5271.171875 MB free)
  Uptime: 525.8 sec
  Load Avg:  1.05  0.89  0.45
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 1 Nov 2022 - 17:43
  • Package commit: 42b5a1
  • Julia commit: 36034a
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 3.827 ms (5%) 315.49 KiB (1%) 4602
["load"] 5.960 s (5%) 4.91 KiB (1%) 94
["load_plot_display"] 11.600 s (5%) 4.66 KiB (1%) 93
["plot"] 474.305 μs (5%) 44.16 KiB (1%) 398

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1441 s          2 s        232 s       2625 s          0 s
       #2  2593 MHz       1555 s          1 s        214 s       2531 s          0 s
  Memory: 6.78125 GB (5322.0859375 MB free)
  Uptime: 436.26 sec
  Load Avg:  1.04  0.83  0.39
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 1 Nov 2022 - 17:44
  • Package commit: f178ae
  • Julia commit: 36034a
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 4.271 s (5%) 15.125 ms 76.43 MiB (1%) 1463021
["load"] 5.823 s (5%) 4.62 KiB (1%) 93
["load_plot_display"] 12.047 s (5%) 17.04 MiB (1%) 345778
["plot"] 612.306 μs (5%) 44.16 KiB (1%) 398

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       2075 s          2 s        252 s       2866 s          0 s
       #2  2593 MHz       1793 s          1 s        222 s       3177 s          0 s
  Memory: 6.78125 GB (5271.171875 MB free)
  Uptime: 525.8 sec
  Load Avg:  1.05  0.89  0.45
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           85
Model name:                      Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Stepping:                        7
CPU MHz:                         2593.908
BogoMIPS:                        5187.81
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        2 MiB
L3 cache:                        35.8 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Comment on lines +13 to +15
:yfill_range => "Number or AbstractVector. Fills area between fillrange and y for line-types, sets the base for bar/stick types, and similar for other types.",
:yfill_color => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.",
:yfill_alpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:yfill_range => "Number or AbstractVector. Fills area between fillrange and y for line-types, sets the base for bar/stick types, and similar for other types.",
:yfill_color => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.",
:yfill_alpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.",
:yfill_range => "Number or AbstractVector. Fills area between fillrange and y for line-types, sets the base for bar/stick types, and similar for other types.",
:yfill_color => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.",
:yfill_alpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.",

:yfill_color => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.",
:yfill_alpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.",
:marker_shape => "Symbol, Shape, or AbstractVector. Choose from $(_allMarkers).",
:yfill_style => "Symbol. Style of the fill area. `nothing` (the default) means solid fill. Choose from :/, :\\, :|, :-, :+, :x",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:yfill_style => "Symbol. Style of the fill area. `nothing` (the default) means solid fill. Choose from :/, :\\, :|, :-, :+, :x",
:yfill_style => "Symbol. Style of the fill area. `nothing` (the default) means solid fill. Choose from :/, :\\, :|, :-, :+, :x",


Takes a `struct` definition and recurses into its fields to create keywords by chaining the field names with the structs' name with underscore.
Also creates pluralized and non-underscore aliases for these keywords.
- `level` indicates which group of `plot`, `subplot`, `series`, etc. the keywords belong to.
- `expr` is the struct definition with default values like `Base.@kwdef`
- `match_table` is an expression of the form `:match = (symbols)`, with symbols whose default value should be `:match`
- `args` can be any of the following
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
- `args` can be any of the following
alias_dict = :(:aliases = Dict{Symbol,Symbol}())

gr_set_transparency(get_fillalpha(series))
h = gr_contour_levels(series, clims)
if series[:fillrange] !== nothing
if series[:yfill_range] !== nothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
if series[:yfill_range] !== nothing
gr_set_line(
get_linewidth(series),
get_linestyle(series),
get_line_color(series),
series,
)

elseif sp[:colorbar_scale] === :log10
z_log = replace(x -> isinf(x) ? NaN : x, log10.(z))
z_normalized = get_z_normalized.(z_log, log10.(clims)...)
plot_color.(map(z -> get(fillgrad, z), z_normalized), series[:fillalpha]), z_log
plot_color.(map(z -> get(fillgrad, z), z_normalized), series[:yfill_alpha]), z_log
end
for i in eachindex(colors)
isnan(_z[i]) && (colors[i] = set_RGBA_alpha(0, colors[i]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
isnan(_z[i]) && (colors[i] = set_RGBA_alpha(0, colors[i]))
plot_color.(map(z -> get(fillgrad, z), z_normalized), series[:yfill_alpha]),
z_log

@@ -50,8 +50,15 @@ end
:legend_font_color,
:legend_title_font_family,
:legend_title_font_color,
) :aliases = Dict(
(:legend, :leg, :key) => :legend_position,
(:bg_legend, :bg_color_legend, :background_legend, :background_colour_legend, :bg_colour_legend, :background_color_legend) => :legend_background_color
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
(:bg_legend, :bg_color_legend, :background_legend, :background_colour_legend, :bg_colour_legend, :background_color_legend) => :legend_background_color
(
:bg_legend,
:bg_color_legend,
:background_legend,
:background_colour_legend,
:bg_colour_legend,
:background_color_legend,
) => :legend_background_color,

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmarks:
    • Target: 2 Nov 2022 - 16:39
    • Baseline: 2 Nov 2022 - 16:40
  • Package commits:
    • Target: b695f5
    • Baseline: f12da4
  • Julia commits:
    • Target: 36034a
    • Baseline: 36034a
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["display"] 0.00 (5%) ✅ 0.00 (1%) ✅
["load"] 1.01 (5%) 1.06 (1%) ❌
["load_plot_display"] 0.94 (5%) ✅ 0.00 (1%) ✅
["plot"] 0.70 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       2290 s          0 s        277 s       3190 s          0 s
       #2  2394 MHz       1479 s          0 s        272 s       4029 s          0 s
  Memory: 6.78125 GB (5281.43359375 MB free)
  Uptime: 588.05 sec
  Load Avg:  1.05  0.96  0.5
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, haswell)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       2609 s          0 s        286 s       4024 s          0 s
       #2  2394 MHz       2301 s          0 s        299 s       4345 s          0 s
  Memory: 6.78125 GB (5326.1953125 MB free)
  Uptime: 704.7 sec
  Load Avg:  1.02  0.98  0.57
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, haswell)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 2 Nov 2022 - 16:39
  • Package commit: b695f5
  • Julia commit: 36034a
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 4.520 ms (5%) 316.71 KiB (1%) 4652
["load"] 7.227 s (5%) 4.91 KiB (1%) 94
["load_plot_display"] 14.497 s (5%) 4.66 KiB (1%) 93
["plot"] 553.103 μs (5%) 44.16 KiB (1%) 398

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       2290 s          0 s        277 s       3190 s          0 s
       #2  2394 MHz       1479 s          0 s        272 s       4029 s          0 s
  Memory: 6.78125 GB (5281.43359375 MB free)
  Uptime: 588.05 sec
  Load Avg:  1.05  0.96  0.5
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, haswell)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 2 Nov 2022 - 16:40
  • Package commit: f12da4
  • Julia commit: 36034a
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 5.477 s (5%) 38.344 ms 76.54 MiB (1%) 1464856
["load"] 7.147 s (5%) 4.62 KiB (1%) 93
["load_plot_display"] 15.349 s (5%) 17.04 MiB (1%) 345778
["plot"] 795.203 μs (5%) 44.16 KiB (1%) 398

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       2609 s          0 s        286 s       4024 s          0 s
       #2  2394 MHz       2301 s          0 s        299 s       4345 s          0 s
  Memory: 6.78125 GB (5326.1953125 MB free)
  Uptime: 704.7 sec
  Load Avg:  1.02  0.98  0.57
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, haswell)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           63
Model name:                      Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping:                        2
CPU MHz:                         2394.455
BogoMIPS:                        4788.91
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        512 KiB
L3 cache:                        30 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor :Intel
Architecture :Haswell
Model Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 30720) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

src/args.jl Outdated

const _keyAliases = Dict{Symbol,Symbol}()
const _generalAliases = ("background" => "bg", "foreground" => "fg", "pointsize" => "size", "yfill" => "fill", "alpha" => "a", "alpha" => "opacity", "alpha" => "α")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
const _generalAliases = ("background" => "bg", "foreground" => "fg", "pointsize" => "size", "yfill" => "fill", "alpha" => "a", "alpha" => "opacity", "alpha" => "α")
const _generalAliases = (
"background" => "bg",
"foreground" => "fg",
"pointsize" => "size",
"yfill" => "fill",
"alpha" => "a",
"alpha" => "opacity",
"alpha" => "α",
)

Comment on lines 2176 to +2181
:(Plots.add_aliases(
$(QuoteNode(exp_key)),
$(QuoteNode(Plots.make_non_underscore(pl_key))),
$(QuoteNode(Plots.make_non_underscore(pl_key)))...,
)),
)
if aliases !== nothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:(Plots.add_aliases(
$(QuoteNode(exp_key)),
$(QuoteNode(Plots.make_non_underscore(pl_key))),
$(QuoteNode(Plots.make_non_underscore(pl_key)))...,
)),
)
if aliases !== nothing
pl_aliases = Plots.makeplural.(aliases)
push!(
insert_block.args,
:(Plots.add_aliases(
$(QuoteNode(exp_key)),
$(aliases)...,
$(pl_aliases)...,
$(Iterators.flatten(Plots.make_non_underscore.(aliases)))...,
$(Iterators.flatten(Plots.make_non_underscore.(pl_aliases)))...,
)),
)

@@ -1788,14 +1788,14 @@ end
function gr_draw_contour(series, x, y, z, clims)
GR.setprojectiontype(0)
GR.setspace(clims[1], clims[2], 0, 90)
gr_set_line(get_linewidth(series), get_linestyle(series), get_linecolor(series), series)
gr_set_line(get_linewidth(series), get_linestyle(series), get_line_color(series), series)
gr_set_transparency(get_fillalpha(series))
h = gr_contour_levels(series, clims)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
h = gr_contour_levels(series, clims)
gr_set_line(
get_linewidth(series),
get_linestyle(series),
get_line_color(series),
series,
)

elseif sp[:colorbar_scale] === :log10
z_log = replace(x -> isinf(x) ? NaN : x, log10.(z))
z_normalized = get_z_normalized.(z_log, log10.(clims)...)
plot_color.(map(z -> get(fillgrad, z), z_normalized), series[:fillalpha]), z_log
plot_color.(map(z -> get(fillgrad, z), z_normalized), series[:yfill_alpha]), z_log
end
for i in eachindex(colors)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
for i in eachindex(colors)
plot_color.(map(z -> get(fillgrad, z), z_normalized), series[:yfill_alpha]),
z_log

Comment on lines +836 to +838
:legend_position => (:legend, :leg, :key),
:legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend),
:legend_foreground_color => (:foreground_legend, :foreground_colour_legend, :foreground_colour_legend)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:legend_position => (:legend, :leg, :key),
:legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend),
:legend_foreground_color => (:foreground_legend, :foreground_colour_legend, :foreground_colour_legend)
:legend_position => (:legend, :leg, :key),
:legend_background_color =>
(:background_legend, :background_colour_legend, :background_color_legend),
:legend_foreground_color =>
(:foreground_legend, :foreground_colour_legend, :foreground_colour_legend),

:line_alpha => (:lalpha,),
:line_width => (:w, :width, :lw),
:line_style => (:s, :style, :ls),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

alpha = nothing
style = nothing
end aliases = Dict(
:yfill_color => (:fc, :fcolor, :fcolour,),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:yfill_color => (:fc, :fcolor, :fcolour,),
:yfill_color => (:fc, :fcolor, :fcolour),

end aliases = Dict(
:yfill_color => (:fc, :fcolor, :fcolour,),
:yfill_alpha => (:falpha,),
:yfill_range => (:yfill_rng, :frange, :yfill_to, :yfill_between)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:yfill_range => (:yfill_rng, :frange, :yfill_to, :yfill_between)
:yfill_range => (:yfill_rng, :frange, :yfill_to, :yfill_between),

@@ -50,8 +50,18 @@ end
:legend_font_color,
:legend_title_font_family,
:legend_title_font_color,
) :aliases = Dict(
:legend_position => (:legend, :leg, :key),
:legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend),
:legend_background_color =>
(:background_legend, :background_colour_legend, :background_color_legend),

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmarks:
    • Target: 3 Nov 2022 - 16:27
    • Baseline: 3 Nov 2022 - 16:29
  • Package commits:
    • Target: e63999
    • Baseline: 1c30e7
  • Julia commits:
    • Target: 36034a
    • Baseline: 36034a
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["display"] 0.00 (5%) ✅ 0.00 (1%) ✅
["load"] 0.99 (5%) 1.06 (1%) ❌
["load_plot_display"] 0.96 (5%) 0.00 (1%) ✅
["plot"] 0.79 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       1471 s          0 s        195 s       1493 s          0 s
       #2  2793 MHz       1575 s          0 s        212 s       1372 s          0 s
  Memory: 6.78125 GB (5302.77734375 MB free)
  Uptime: 325.01 sec
  Load Avg:  1.2  0.88  0.41
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       2236 s          0 s        214 s       1610 s          0 s
       #2  2793 MHz       1689 s          0 s        220 s       2151 s          0 s
  Memory: 6.78125 GB (5333.4140625 MB free)
  Uptime: 415.27 sec
  Load Avg:  1.12  0.93  0.48
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 3 Nov 2022 - 16:27
  • Package commit: e63999
  • Julia commit: 36034a
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 3.831 ms (5%) 317.10 KiB (1%) 4664
["load"] 5.775 s (5%) 4.91 KiB (1%) 94
["load_plot_display"] 12.070 s (5%) 4.65 KiB (1%) 93
["plot"] 475.003 μs (5%) 43.75 KiB (1%) 403

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       1471 s          0 s        195 s       1493 s          0 s
       #2  2793 MHz       1575 s          0 s        212 s       1372 s          0 s
  Memory: 6.78125 GB (5302.77734375 MB free)
  Uptime: 325.01 sec
  Load Avg:  1.2  0.88  0.41
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

  • Time of benchmark: 3 Nov 2022 - 16:29
  • Package commit: 1c30e7
  • Julia commit: 36034a
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["display"] 4.802 s (5%) 28.377 ms 103.86 MiB (1%) 1950401
["load"] 5.807 s (5%) 4.62 KiB (1%) 93
["load_plot_display"] 12.611 s (5%) 17.04 MiB (1%) 345778
["plot"] 600.703 μs (5%) 43.75 KiB (1%) 403

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.2
Commit 36034abf260 (2022-09-29 15:21 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       2236 s          0 s        214 s       1610 s          0 s
       #2  2793 MHz       1689 s          0 s        220 s       2151 s          0 s
  Memory: 6.78125 GB (5333.4140625 MB free)
  Uptime: 415.27 sec
  Load Avg:  1.12  0.93  0.48
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           106
Model name:                      Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Stepping:                        6
CPU MHz:                         2793.437
BogoMIPS:                        5586.87
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       96 KiB
L1i cache:                       64 KiB
L2 cache:                        2.5 MiB
L3 cache:                        48 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Vendor :Intel
Architecture :UnknownIntel
Model Family: 0x06, Model: 0x6a, Stepping: 0x06, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (48, 1280, 49152) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft


const _keyAliases = Dict{Symbol,Symbol}()
const _generalAliases = ("background" => "bg", "foreground" => "fg", "pointsize" => "size", "yfill" => "fill", "alpha" => "a", "alpha" => "opacity", "alpha" => "α", "errorbar" => "error")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
const _generalAliases = ("background" => "bg", "foreground" => "fg", "pointsize" => "size", "yfill" => "fill", "alpha" => "a", "alpha" => "opacity", "alpha" => "α", "errorbar" => "error")
const _generalAliases = (
"background" => "bg",
"foreground" => "fg",
"pointsize" => "size",
"yfill" => "fill",
"alpha" => "a",
"alpha" => "opacity",
"alpha" => "α",
"errorbar" => "error",
)

for letter in (:X, :Y, :Z)
### Errorbars
@eval @add_attributes series struct $(Symbol(letter, :ErrorBar))
marker::Marker = Marker(shape = getproperty(( X = :vline, Y = :hline, Z = :hline), letter))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
marker::Marker = Marker(shape = getproperty(( X = :vline, Y = :hline, Z = :hline), letter))
marker::Marker =
Marker(shape = getproperty((X = :vline, Y = :hline, Z = :hline), letter))

alpha = nothing
style = nothing
end :aliases = Dict(
:yfill_color => (:fc, :fcolor, :fcolour,),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:yfill_color => (:fc, :fcolor, :fcolour,),
:yfill_color => (:fc, :fcolor, :fcolour),

end :aliases = Dict(
:yfill_color => (:fc, :fcolor, :fcolour,),
:yfill_alpha => (:falpha,),
:yfill_range => (:yfill_rng, :frange, :yfill_to, :yfill_between)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
:yfill_range => (:yfill_rng, :frange, :yfill_to, :yfill_between)
:yfill_range => (:yfill_rng, :frange, :yfill_to, :yfill_between),

:yfill_range => (:yfill_rng, :frange, :yfill_to, :yfill_between)
)
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant