[bsdiff_classic] Update Bzip2 compat #9648
Conversation
This will help testing https://github.com/JuliaIO/BSDiff.jl/pull/49/files
| @@ -3,11 +3,11 @@ | |||
| using BinaryBuilder, Pkg | |||
|
|
|||
| name = "bsdiff_classic" | |||
| version = v"4.3.0" | |||
There was a problem hiding this comment.
Does this need to be updated or should I leave it as 4.3.0?
There was a problem hiding this comment.
You do need to change the version number if compat bounds change (and you changed also the julia one below)
| @@ -3,11 +3,11 @@ | |||
| using BinaryBuilder, Pkg | |||
|
|
|||
| name = "bsdiff_classic" | |||
| version = v"4.3.0" | |||
There was a problem hiding this comment.
You do need to change the version number if compat bounds change (and you changed also the julia one below)
Co-authored-by: Mosè Giordano <[email protected]>
|
License file is missing |
Nice catch. |
| @@ -17,6 +17,7 @@ perl -i -ple '$_ = "#include <sys/types.h>\n" . $_ if $. == 31' bspatch.c | |||
| cc -O3 -lbz2 -I"${prefix}/include" bsdiff.c -o bsdiff | |||
| cc -O3 -lbz2 -I"${prefix}/include" bspatch.c -o bspatch | |||
| install bsdiff bspatch "${bindir}" | |||
| install_license bsdiff.c bspatch.c | |||
There was a problem hiding this comment.
Using source code as license file isn't a great idea. That seems to be 2-clause BSD, we have that somewhere in the rootfs
There was a problem hiding this comment.
It should be
| install_license bsdiff.c bspatch.c | |
| install_license /usr/share/licenses/BSD2 |
This will help testing JuliaIO/BSDiff.jl#49