-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCS] link against libblastrampoline #9608
base: master
Are you sure you want to change the base?
Conversation
This needs a new version number (and then some changes to SCS.jl), so let's just wait for the next upstream release. |
there's also a build failure due to libblastrampoline not found on aarch64-unknown-freebsd, is that expected @giordano ? |
@ararslan what version of libblastrampoline supports aarch64-freebsd? Is it easier to just skip that platform? |
Should we move freebsd-aarch64 to experimental until Julia 1.12 is out? |
The experimental option didn't work very well because it's a moving target, I prefer being explicit. My general approach with building a package for such a niche platform like aarch64-freebsd is "if it works easily, awesome, if it takes too much effort to make it work then just exclude it and move on". |
I believe it's 5.11.0. I can do a rebuild of 5.4.0 if needed. |
should we filter platforms and create two separate deps with different compat for blastrampoline? What is the compat we should use when targeting julia-1.10 and higher? |
I believe the only thing to do for now is to filter out freebsd aarch64. |
IIUC, libblastrampoline is the rare example where bumping the compat is not a problem. I went through a similar situation recently and that was my takeaway. Perhaps @giordano can confirm? |
stdlibs are always bound to a specific version of Julia. I think you did recently on suitesparse, which is a stdlib itself, so the problem doesn't really matter there. |
Ah right, okay. Looking at the builders that depend on libblastrampoline, the most common compat setting is 5.4, so perhaps it could be worthwhile to rebuild that anyway. |
@ararslan let me know when rebuilt is ready! |
Both 1.10.5 and 1.11.0 have libblastrampoline 5.11.0. However 1.10.0 has LBT 5.4. |
Trying LBT update in in #9641 |
whenever it makes sense;
No changes to scsmkl, since it is already linked against mkl directly.
CC: @odow