Skip to content

Commit

Permalink
Merge pull request #84 from chriselrod/turbofindmax
Browse files Browse the repository at this point in the history
Turbo findmax
  • Loading branch information
chriselrod authored Aug 10, 2023
2 parents 2837b3e + 753c558 commit 75ca426
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "RecursiveFactorization"
uuid = "f2c3362d-daeb-58d1-803e-2bc74f2840b4"
authors = ["Yingbo Ma <[email protected]>"]
version = "0.2.19"
version = "0.2.20"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
11 changes: 5 additions & 6 deletions src/lu.jl
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ end
end

@inline function nsplit(::Type{T}, n) where {T}
k = max(2, 512 ÷ (isbitstype(T) ? sizeof(T) : 8))
k = max(2, 128 ÷ (isbitstype(T) ? sizeof(T) : 8))
k_2 = k ÷ 2
return n >= k ? ((n + k_2) ÷ k) * k_2 : n ÷ 2
end
Expand Down Expand Up @@ -277,12 +277,11 @@ function _generic_lufact!(A, ::Val{Pivot}, ipiv, info) where {Pivot}
kp = k
if Pivot
amax = abs(zero(eltype(A)))
for i in k:m
@turbo warn_check_args=false for i in k:m
absi = abs(A[i, k])
if absi > amax
kp = i
amax = absi
end
isnewmax = absi > amax
kp = isnewmax ? i : kp
amax = isnewmax ? absi : amax
end
ipiv[k] = kp
end
Expand Down

5 comments on commit 75ca426

@chriselrod
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Register Failed
@chriselrod, it looks like you are not a publicly listed member/owner in the parent organization (JuliaLinearAlgebra).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@chriselrod
Copy link
Contributor Author

@chriselrod chriselrod commented on 75ca426 Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YingboMa @ChrisRackauckas want to make a release?

@YingboMa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/89384

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.20 -m "<description of version>" 75ca4263728eacf4c0404dc0b1b1d11354b3c01b
git push origin v0.2.20

Please sign in to comment.