-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document gotchas when interoperation with python #804
base: master
Are you sure you want to change the base?
Conversation
docs/src/h5py.md
Outdated
|
||
The whole example as a Julia executable script: | ||
```julia | ||
using PyCall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add PyCall
as a test dependency and turn this into a doctest. However it might be fragile since we need to install h5py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is possible to use Conda.jl
to install the hdf5 library in order to turn these to doctests. I'm not opposed to adding a PyCall test dependency. In general, it does seem to be a good idea to ensure inter-op.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but this introduces further headaches. If you run tests locally using e.g. system python things may fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this anyway.
BTW is it intended, that CI passes, despite the doctest fail? |
It shouldn't, not sure why it passed yet. |
I'm trying to decide if we should add |
The only reason is, that I find it easier to develop a |
@musm https://github.com/JuliaIO/HDF5.jl/runs/1762155054?check_suite_focus=true#step:4:112 ideas? I cannot reproduce this error locally. |
Let's try running thing again here |
#785