Check the dimensions of child geoms when rebuilding #239
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks that all the child geometries have the same dimension, before rebuilding a geometry. This enables functions like `forcexy` etc, as well as 2D to 3D transformations (or vice versa).
|
Looks good. Only question is the performance cost |
rafaqz
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that all the child geometries have the same dimension, before rebuilding a geometry. This enables functions like
forcexyetc, as well as 2D to 3D transformations (or vice versa).There is room for efficiency since we currently check all child geoms - we could theoretically only check the first. Is that something we want to do?
Fixes #183