Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not export contains #233

Merged
merged 1 commit into from
Nov 26, 2024
Merged

do not export contains #233

merged 1 commit into from
Nov 26, 2024

Conversation

alex-s-gardner
Copy link
Contributor

do not export to avoid conflict with Base.contains

@alex-s-gardner alex-s-gardner mentioned this pull request Nov 15, 2024
Open
asinghvi17
asinghvi17 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@asinghvi17 asinghvi17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we should look into an @enable_base_predicates macro, to hook geometry types into GeometryOps predicates. But this is probably not the time to look into that.

@alex-s-gardner
Copy link
Contributor Author

At some point, we should look into an @enable_base_predicates macro, to hook geometry types into GeometryOps predicates. But this is probably not the time to look into that.

Agreed. I'm not sure what @rafaqz thoughts are on that but one of the things I love about multiple dispatch is not having to do "Package.function" when the operation is intuitive as to it's purpose.

@rafaqz rafaqz merged commit 6d51c7f into main Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinghvi17 asinghvi17 asinghvi17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-s-gardner @asinghvi17 @rafaqz