Restore Halogen recipes #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-murphy
force-pushed
the
pm/restore-halogen-recipes
branch
from
af8a950
to
42d3448
Compare
pete-murphy
force-pushed
the
pm/restore-halogen-recipes
branch
2 times, most recently
from
2088ecc
to
88bb42b
Compare
pete-murphy
force-pushed
the
pm/restore-halogen-recipes
branch
from
88bb42b
to
270c0f8
Compare
| @@ -0,0 +1,5 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Can we get rid of 'use strict' here?
There was a problem hiding this comment.
Yep, it's not needed 👍
JordanMartinez
approved these changes
Aug 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203
Restoring some broken Halogen recipes. The
DriverWebSocketsHalogenHooksis adapted from the work in this PR purescript-halogen/purescript-halogen#804, consolidated to a single component to be TryPureScript-friendly, and using the-hooksversion of the component from the original recipe. Aside from that, the other recipes were fixed by just following the guidance of the changelog https://github.com/purescript-halogen/purescript-halogen/blob/master/docs/changelog/v6.md.Also made an unrelated change to fix the naming of a function in one of the
DogImagesrecipes (randomCatGif→randomDogImage) 42d3448