-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional seenfromClass to ThisTypeSubstitution #663
base: idea242.x
Are you sure you want to change the base?
Conversation
Pass in the context class of the member whose type is being substituted (analagous to the `seenFromClass` passed to scalac's asSeenFrom). Use this to guide the walk through enclosing classes. Also, fix basetypes handling around ScThisType
c7b5561
to
7850de5
Compare
@dwijnand Thanks for the PR! I'll look into it in the next couple of days. |
@sugakandrey any thoughts? |
@dwijnand I am sorry for the delay, I have not forgotten about this PR, despite how it might look. :) |
For the record, I built the plugin with this change and tested it on scala/scala. It fixes the issue I reported (https://youtrack.jetbrains.com/issue/SCL-21947). |
@dwijnand
I can try fixing them after I'm done with the stuff I'm working on right now or you can have a stab at it. |
I'm in a similar place. I'll ping when I reproduce those failures. |
OK, I have the failures locally (can't remember if all of those failed) and I have a fix in the works. |
@sugakandrey Could you give it another run? I found the fixes for testScalacTests, testDependent, and testRecursiveTypeAlias. But I minimised testHighlighting down to it passing and then back up to a minimised failure, and fix it, but hadn't realised that - for some reason - it doesn't pass locally for me even without my changes (I think!). So if you could rerun the tests, I can reassess from there. |
@dwijnand I'll give it a spin tomorrow. |
@dwijnand All seems to be in good order, I'll merge it manually into 243 nightlies. |
Pass in the context class of the member whose type is being substituted
(analagous to the
seenFromClass
passed to scalac's asSeenFrom). Usethis to guide the walk through enclosing classes.
Also, fix basetypes handling around ScThisType
Fixes SCL-21585
Fixes SCL-21947