-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CommandBuilder, arguments, etc. #979
Refactor CommandBuilder, arguments, etc. #979
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1d9e8ac - Browse repository at this point
Copy the full SHA 1d9e8acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 599c0ed - Browse repository at this point
Copy the full SHA 599c0edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43a81b1 - Browse repository at this point
Copy the full SHA 43a81b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 076fc15 - Browse repository at this point
Copy the full SHA 076fc15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0636872 - Browse repository at this point
Copy the full SHA 0636872View commit details -
Remove count from motion argument
Only Command has a count. The motion argument is now a sealed class hierarchy, and consists only of the motion action and optional argument. This is to reduce confusion over which count to use, and potential incorrect calculation of the count
Configuration menu - View commit details
-
Copy full SHA for 9106517 - Browse repository at this point
Copy the full SHA 9106517View commit details
Commits on Aug 28, 2024
-
Fixes selecting last register if multiple registers are used in a command
Configuration menu - View commit details
-
Copy full SHA for e2a37ce - Browse repository at this point
Copy the full SHA e2a37ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ff6bf9 - Browse repository at this point
Copy the full SHA 7ff6bf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f32a9b - Browse repository at this point
Copy the full SHA 6f32a9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98ad763 - Browse repository at this point
Copy the full SHA 98ad763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 868f428 - Browse repository at this point
Copy the full SHA 868f428View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37ef432 - Browse repository at this point
Copy the full SHA 37ef432View commit details -
Configuration menu - View commit details
-
Copy full SHA for 813d16f - Browse repository at this point
Copy the full SHA 813d16fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c9392 - Browse repository at this point
Copy the full SHA f6c9392View commit details -
Remove KeyHandler.isOperatorPending
It's easier to just look at mode. We don't need the additional check on command builder, because we can't be in OP_PENDING without pushing an operator action to the command builder
Configuration menu - View commit details
-
Copy full SHA for a8d5ffb - Browse repository at this point
Copy the full SHA a8d5ffbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d173d50 - Browse repository at this point
Copy the full SHA d173d50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a9b340 - Browse repository at this point
Copy the full SHA 2a9b340View commit details -
Deprecate OperatorArguments.isOperatorPending
Register specific handlers for Operator-pending mode instead of relying on a runtime flag for behaviour. Also refactors and renames some arrow motion handlers.
Configuration menu - View commit details
-
Copy full SHA for f09a7e7 - Browse repository at this point
Copy the full SHA f09a7e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8077809 - Browse repository at this point
Copy the full SHA 8077809View commit details -
Remove OperatorArguments.mode usage in block insert
`OperatorArguments.mode` is the mode *before* the command is completed, so might be Visual, Operator-pending, Insert, etc. It's not immediately obvious this is the case, so we're going to deprecate `OperatorArguments.mode` to avoid confusion with `editor.mode`. It's not required for this method because it's only called for Visual-block mode.
Configuration menu - View commit details
-
Copy full SHA for 4f2dad8 - Browse repository at this point
Copy the full SHA 4f2dad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04dece7 - Browse repository at this point
Copy the full SHA 04dece7View commit details -
Use editor.mode instead of OperatorArguments.mode
`OperatorArguments.mode` is the mode *before* the command was completed, rather than the current mode, which is non-obvious. E.g. for a command in Insert mode, it will still be Insert, and for a (simple) command in Normal, it will still be Normal. The only difference is that a command such as `dw` would be in Operator-pending before the command is completed. That logic is not required for this method, so it's safe to use the current mode. This allows us to start to deprecate `OperatorArguments.mode`.
Configuration menu - View commit details
-
Copy full SHA for 80ee4e2 - Browse repository at this point
Copy the full SHA 80ee4e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77ae379 - Browse repository at this point
Copy the full SHA 77ae379View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9db95e8 - Browse repository at this point
Copy the full SHA 9db95e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6a3e15 - Browse repository at this point
Copy the full SHA d6a3e15View commit details -
Start to encapsulate setting command builder state
Also rename `pushCommandPart` and `completeCommandPart`
Configuration menu - View commit details
-
Copy full SHA for 6288814 - Browse repository at this point
Copy the full SHA 6288814View commit details -
Reorder CommandBuilder methods
Try to keep related functions together: awaiting arguments, count, registers, adding action/argument, processing keystrokes, build, reset.
Configuration menu - View commit details
-
Copy full SHA for 328cd75 - Browse repository at this point
Copy the full SHA 328cd75View commit details
Commits on Aug 29, 2024
-
Ensure builder resets to a root command trie node
Also refactors command nodes a bit for better debug/trace output
Configuration menu - View commit details
-
Copy full SHA for 7c4a2ca - Browse repository at this point
Copy the full SHA 7c4a2caView commit details -
Encapsulate the command builder's state flag
This also gets rid of BAD_COMMAND, which was set but never checked - the function that set the flag would immediately reset the command builder
Configuration menu - View commit details
-
Copy full SHA for 06ff832 - Browse repository at this point
Copy the full SHA 06ff832View commit details