New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIM-1824: surround - remove whitespace with closing bracket #1007

Open

trimailov wants to merge 1 commit into JetBrains:master from trimailov:VIM-1824

trimailov commented Oct 10, 2024 •

edited

Loading

Context:

In vim surround extension closing brackets (}, ], )) should remove whitespace when using cs movement.

Example:

Before: { example }
Movement: cs{}
After: {example}

This doesn't work currently. The text is left unchanged.

Solution:

The bug was because brackets were replaced with a string from SURROUND_PAIRS map, which does not have any context about removing characters.

Inspired from VSCode's VIM plugin¹, I have introduced new class SurroundPair that will carry this context about the need to trim characters.

Disclaimer:

I have never written in Kotlin so solution may be not use best practices, though at least this PR seems to fix the problem and tests are passing.

Ticket:

https://youtrack.jetbrains.com/issue/VIM-1824/Vim-Surround-Does-not-remove-whitespace-with-the-closing-bracket

https://github.com/VSCodeVim/Vim/blob/04fe42aa815f638af14e4cf4c92e88109242c3e6/src/actions/plugins/surround.ts#L455 ↩


          [VIM-1824] surround - remove whitespace with closing bracket

6089a2d

**Context**:

In vim surround extendsion closing brackets (`}, ], )`) should remove
whitespace when using `cs` movement.

Example:
- Before: `{ example }`
- Movement: `cs{}`
- After: `{example}`

This was because  were replaced with a string from `SURROUND_PAIRS` map,
which does not have any context about removing characters.

**Solution**:

Inspired from VSCode's VIM plugin[^1], I have introduced new class
`SurroundPair` that will carry this context about need to trim
characters.

**Disclaimer**:

I have never written in `Kotlin` so solution may be not use best
practices, though at least this PR seems to fix the problem and tests
are passing.

**Ticket**:
- https://youtrack.jetbrains.com/issue/VIM-1824/Vim-Surround-Does-not-remove-whitespace-with-the-closing-bracket

[^1]: https://github.com/VSCodeVim/Vim/blob/04fe42aa815f638af14e4cf4c92e88109242c3e6/src/actions/plugins/surround.ts#L455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet