-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a globFileUploadParamsList option to set properties on uploaded files #410
add a globFileUploadParamsList option to set properties on uploaded files #410
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 06c4a36. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
67ffca0
to
f51697b
Compare
I just deleted the package-lock changes. |
const { outputPath } = await context.getTargetOptions( | ||
targetFromTargetString(buildTarget.name) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed this here since I'm using @nrwl/web:webpack
for building my app and the outputPath property is not part of the buildResult object that is returned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @Jefiozie I needed it right away so I published my version of the package with changes from #409 and #410 |
Hi @maxletourneur , could you resolve the conflict? Also would you run the command |
I resolved the conflict and ran |
06c4a36
to
a453cd4
Compare
Thanks for the update here try to merge it upcoming week. See some errors will have a look at it. |
a453cd4
to
2316fd3
Compare
Just cleaned up my PR from a bunch of files I didn't intend to update originally. |
2316fd3
to
14cc162
Compare
14cc162
to
263df3b
Compare
ok, fixed them, just some prettier conflicts, should be ready to merge 🚀 |
Created an option to pass params when the s3.upload method is called on selected files.
I added the documentation to the readme, let me know if that isn't clear.
For my use case I need my files to have a CacheControl property set and an ACL.
More info about the possible params here:
https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#upload-property