Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a globFileUploadParamsList option to set properties on uploaded files #410

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

maxletourneur
Copy link
Contributor

@maxletourneur maxletourneur commented Apr 18, 2022

Created an option to pass params when the s3.upload method is called on selected files.
I added the documentation to the readme, let me know if that isn't clear.
For my use case I need my files to have a CacheControl property set and an ACL.
More info about the possible params here:
https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#upload-property

@nx-cloud
Copy link

nx-cloud bot commented Apr 18, 2022

@maxletourneur
Copy link
Contributor Author

I just deleted the package-lock changes.

Comment on lines +93 to +91
const { outputPath } = await context.getTargetOptions(
targetFromTargetString(buildTarget.name)
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed this here since I'm using @nrwl/web:webpack for building my app and the outputPath property is not part of the buildResult object that is returned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxletourneur
Copy link
Contributor Author

FYI @Jefiozie I needed it right away so I published my version of the package with changes from #409 and #410
https://www.npmjs.com/package/@maxletou/ngx-aws-deploy
Will deprecate as soon as this feature gets merged.

@Jefiozie
Copy link
Owner

Hi @maxletourneur , could you resolve the conflict? Also would you run the command npx nx format and see if the formatting will be better after it? Looks like something happend there. Maybe I just forgot it at some point but would appreciate it if you would check this on your end.

@Jefiozie Jefiozie assigned maxletourneur and unassigned Jefiozie Apr 27, 2022
@maxletourneur
Copy link
Contributor Author

Hi @maxletourneur , could you resolve the conflict? Also would you run the command npx nx format and see if the formatting will be better after it? Looks like something happend there. Maybe I just forgot it at some point but would appreciate it if you would check this on your end.

I resolved the conflict and ran npx nx format, looks like it's ready to merge! 🚀 @Jefiozie

@maxletourneur maxletourneur removed their assignment May 1, 2022
@Jefiozie
Copy link
Owner

Thanks for the update here try to merge it upcoming week. See some errors will have a look at it.

@maxletourneur
Copy link
Contributor Author

Thanks for the update here try to merge it upcoming week. See some errors will have a look at it.

Just cleaned up my PR from a bunch of files I didn't intend to update originally.

@maxletourneur
Copy link
Contributor Author

Thanks for the update here try to merge it upcoming week. See some errors will have a look at it.

ok, fixed them, just some prettier conflicts, should be ready to merge 🚀

@Jefiozie Jefiozie merged commit d921f55 into Jefiozie:main Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants