Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the Robotics academy electron app #2173

Open
wants to merge 2 commits into
base: old_manager
Choose a base branch
from

Conversation

Prakhar-commits
Copy link
Contributor

This PR allows the Robotics academy electron app to start Django server within the electron instance.

Fixed #2172

@Bhardwaj-Himanshu
Copy link
Contributor

Hi @Prakhar-commits The change is very welcomed!

But as these are some huge amounts of code committed, could you check building the docker files? Also, a visual representation from your local machine of how things are working after the changes you made in form of a visual video format would be very helpful!

@Prakhar-commits
Copy link
Contributor Author

Hi @Prakhar-commits The change is very welcomed!

But as these are some huge amounts of code committed, could you check building the docker files? Also, a visual representation from your local machine of how things are working after the changes you made in form of a visual video format would be very helpful!

Hi @Bhardwaj-Himanshu This code will be committed to a different repo. not in this one will as a separate repo is available for desktop-application. also I am currently working on the docker part only

@Bhardwaj-Himanshu
Copy link
Contributor

Understood then @Prakhar-commits! Keep up those changes!🫂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved electron app
2 participants