nv2a: Always specify GL texture swizzle #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds explicit swizzle information to each texture format.
Currently, we have a manual check if the mask is
{0,0,0,0}
to figure out if we want want to avoid the GL texture swizzle. However{0,0,0,0}
is the same as{GL_ZERO,GL_ZERO,GL_ZERO,GL_ZERO}
(a valid state). But when we don't want GL texture swizzle, we'd actually need{GL_RED,GL_GREEN,GL_BLUE,GL_ALPHA}
.So instead of falling back to
{0,0,0,0}
, this adds the default mask instead. For texture storage formats without alpha, I've modified the default mask to{GL_RED,GL_GREEN,GL_BLUE,GL_ONE}
. If this has a performance impact, we can change it back to the default mask.Motivation:
When we have signed textures, we will probably have to read the swizzle mask elsewhere, so copying the check for
{0,0,0,0}
is very annoying.Also, we might need more fields for textures in the near future, so it's good to have the struct fully initialized.
TODO: