Merge pull request #49 from ItzNotABug/48-fix-invalid-url-host

Fix `ERR_INVALID_URL`.
ItzNotABug · Apr 4, 2024 · ee3b024 · ee3b024
2 parents 8b7a793 + 56a2084
commit ee3b024
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "ghosler",
   "description": "Send newsletter emails to your members, using your own email credentials!",
-  "version": "0.96",
+  "version": "0.97",
   "private": true,
   "main": "app.js",
   "type": "module",

diff --git a/utils/newsletter.js b/utils/newsletter.js
@@ -234,10 +234,18 @@ export default class Newsletter {
             let elementUrl = $(element).attr(tag);
             if (elementUrl === '#' || !elementUrl) return;
 
+            /** @type {string | null} */
+            let urlHost = null;
+
             elementUrl = he.decode(elementUrl);
-            const urlHost = new URL(elementUrl).host;
 
-            if (!domainsToExclude.includes(urlHost) && !urlsToExclude.includes(elementUrl)) {
+            try {
+                urlHost = new URL(elementUrl).host;
+            } catch (error) {
+                logError(logTags.Newsletter, Error(`Invalid URL found: ${elementUrl}, ${error.stack}.`));
+            }
+
+            if (urlHost && !domainsToExclude.includes(urlHost) && !urlsToExclude.includes(elementUrl)) {
                 trackedLinks.add(elementUrl);
                 $(element).attr(tag, `${pingUrl}${elementUrl}`);
             }