Merge pull request #37 from ItzNotABug/fix-36-null-url-decoding-crash

Fix #36.
ItzNotABug · Mar 18, 2024 · b91ed84 · b91ed84
2 parents 3f43079 + e30f24f
commit b91ed84
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "ghosler",
   "description": "Send newsletter emails to your members, using your own email credentials!",
-  "version": "0.92",
+  "version": "0.93",
   "private": true,
   "main": "app.js",
   "type": "module",

diff --git a/utils/newsletter.js b/utils/newsletter.js
@@ -213,9 +213,8 @@ export default class Newsletter {
             renderingData.newsletter.unsubscribeLink,
             renderingData.newsletter.feedbackLikeLink,
             renderingData.newsletter.feedbackDislikeLink,
-            // featuredImage can be null, so we should to filter them.
-            ...renderingData.post.latestPosts.filter(post => post.featuredImage).map(post => post.featuredImage)
-        ].forEach(internalLinks => urlsToExclude.push(he.decode(internalLinks)));
+            ...renderingData.post.latestPosts.map(post => post.featuredImage)
+        ].forEach(linkToTrack => linkToTrack && urlsToExclude.push(he.decode(linkToTrack)));
 
         const trackedLinks = new Set();
         const $ = cheerio.load(renderedPostData);