Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-align call to sum-buddy with its updated parameter #26

Merged
merged 1 commit into from
Oct 2, 2024
Merged

re-align call to sum-buddy with its updated parameter #26

merged 1 commit into from
Oct 2, 2024

Conversation

egrace479
Copy link
Member

In this sum-buddy update the input_directory parameter for get_checksums was changed to input_path, so cautious-robot couldn't get checksums of the downloaded images. This PR changes that parameter in the function call.

@egrace479 egrace479 added the bug Something isn't working label Oct 2, 2024
thompsonmj
thompsonmj approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@thompsonmj thompsonmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egrace479 egrace479 merged commit 002c6a8 into main Oct 2, 2024
8 checks passed
@egrace479 egrace479 deleted the sumbuddy-call branch October 2, 2024 15:54
zoeduan
zoeduan reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@zoeduan zoeduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoeduan zoeduan zoeduan left review comments

@thompsonmj thompsonmj thompsonmj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egrace479 @zoeduan @thompsonmj