Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home button reverts Desktop Mode #1117

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felipeerias
Copy link
Collaborator

Pressing the Home button will revert Desktop Mode back to the default.

This helps the case where the user is visiting some of the links in the home page, where some of them require Desktop Mode and some don't.

Pressing the Home button will revert Desktop Mode back to the default.

This helps the case where the user is visiting some of the links in
the home page, where some of them require Desktop Mode and some don't.
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but I am not sure we want this. The desktop mode is now visible with an icon so the user should be able to see that they are in desktop mode now. Apart from that note that the start page is configurable by the user. They might want the start page to be whatever they want.

If we want to do something we better add some mechanism to automatically exit desktop mode when we have automatically entered it.

@svillar
Copy link
Member

svillar commented May 2, 2024

What should we do with this @felipeerias ?

@svillar svillar marked this pull request as draft August 12, 2024 11:57
@svillar
Copy link
Member

svillar commented Oct 15, 2024

What should we do with this @felipeerias ?

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants