Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Remove envs instanciations during module init #37

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

MathisFederico
Copy link
Collaborator

This required a few modifications of MineHCraft that provoque some failures of both HEBG and ENHSP.

During investigations on HEBG's failures on MineHCraft, some more modifications were made:

  • Add state.as_dict for easier debug
  • Going to STRONGHOLD was consuming OPEN_NETHER_PORTAL instead of ENDER_EYE, still to avoid some planning problems with HEBG for now, we simply use an ENDER_EYE instead of consuming 2.

Still five new items are now failing on MineHCraft with ENHSP ("reeds", "wood_pickaxe", "wood_axe", "cobblestone", "coal") (#36)

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.28% (target: -1.00%) 77.78%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a283ef3) 3433 3234 94.20%
Head commit (1af3f87) 3469 (+36) 3258 (+24) 93.92% (-0.28%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#37) 54 42 77.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@MathisFederico MathisFederico merged commit 58117b0 into master Jan 16, 2024
16 checks passed
@MathisFederico MathisFederico deleted the performance/light-init branch January 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant