Skip to content

Commit

Permalink
Fix PyYAML Checks (#145)
Browse files Browse the repository at this point in the history
* Fix PyYAML Checks

* fix: test another fix

* fix: add the Cython pin to the static checks

* fix: add the fix to the tests

* docs: changelog
  • Loading branch information
ThomasLaPiana authored Aug 9, 2023
1 parent 1b42135 commit 4b20019
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/pr_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ jobs:
python-version: "3.10.11"
cache: "pip"

- name: Pin Cython
run: |
echo 'Cython < 3.0' > /tmp/constraint.txt
PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
pip install 'PyYAML==5.4.1'
- name: Install Package
run: pip install .

Expand All @@ -72,6 +78,12 @@ jobs:
python-version: ${{ env.DEFAULT_PYTHON_VERSION }}
cache: "pip"

- name: Pin Cython
run: |
echo 'Cython < 3.0' > /tmp/constraint.txt
PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
pip install 'PyYAML==5.4.1'
- name: Install Nox
run: pip install nox

Expand All @@ -96,6 +108,12 @@ jobs:
python-version: ${{ matrix.python_version }}
cache: "pip"

- name: Pin Cython
run: |
echo 'Cython < 3.0' > /tmp/constraint.txt
PIP_CONSTRAINT=/tmp/constraint.txt pip wheel PyYAML==5.4.1
pip install 'PyYAML==5.4.1'
- name: Install Nox
run: pip install nox

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The types of changes are:
### Fixed

- Don't allow duplicate entries for DatasetCollections as part of Datasets [#136](https://github.com/ethyca/fideslang/pull/136)
- Cython/PyYAML versions breaking builds [#145](https://github.com/ethyca/fideslang/pull/145)

## [1.4.3](https://github.com/ethyca/fideslang/compare/1.4.2...1.4.3)

Expand Down

0 comments on commit 4b20019

Please sign in to comment.