Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for per-request timeouts #43

Open
wants to merge 2 commits into
base: jh/upgrade-basepom
Choose a base branch
from

Conversation

jhaber
Copy link
Member

@jhaber jhaber commented Nov 2, 2023

Depends on #42

I need to add some unit tests but this theoretically allows clients to specify per-request timeouts, which is somewhat niche but a lifesaver when you do it need it 😄

@stevie400 @Xcelled @suruuK

@stevie400
Copy link
Contributor

stevie400 commented Nov 2, 2023

LGTM w/ tests :)

@jhaber
Copy link
Member Author

jhaber commented Nov 3, 2023

Added some tests in 359e79b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants