Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: depend on gettext #194890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bash: depend on gettext #194890

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This currently vendors its own, but we should use the gettext formula
instead.

Also:

  • Instead of hardcoding a bunch of paths in DEFAULT_LOADABLE_BUILTINS_PATH,
    let's just set the right -rpath flag instead. This is sufficient to
    help bash find loadable modules inside lib/bash.
  • Move a bunch of files in lib/bash into better locations.

This currently vendors its own, but we should use the `gettext` formula
instead.

Also:
- Instead of hardcoding a bunch of paths in `DEFAULT_LOADABLE_BUILTINS_PATH`,
  let's just set the right `-rpath` flag instead. This is sufficient to
  help bash find loadable modules inside `lib/bash`.
- Move a bunch of files in `lib/bash` into better locations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant