Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgconf: drop-in replacement for pkg-config #194885

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest retiring pkg-config already too. i.e. Let's delete it and add a formula rename for pkg-config -> pkgconf.

@cho-m
Copy link
Member Author

cho-m commented Oct 18, 2024

I suggest retiring pkg-config already too. i.e. Let's delete it and add a formula rename for pkg-config -> pkgconf.

That's a bit complicated as audit doesn't like usage of old names / aliases.

Assuming audit is not changed, either need to:

  • Do a giant syntax-only migration of all pkg-config usage to pkgconf.
  • Make pkg-config into a transitional formula that just installs pkgconf and then do the migration at a more leisurely pace. At the end, can squash pkg-config formula to either be a rename/alias of pkgconf.

@carlocab
Copy link
Member

We can just add a temporary exception for pkg-config and do the migration gradually.

@Bo98
Copy link
Member

Bo98 commented Oct 18, 2024

Am OK with this PR given pkgconf and pkg-config are already conflicting.

In terms of switching our uses to pkgconf, the requirements are:

  • pkgconf cannot conflict with pkg-config
  • brew install pkg-config must continue to work (I'd probably go as far as saying it should continue to do so without warnings, i.e. as an alias)

Merging via renames and merging via alias however works completely differently. One uses the migrator mechanism and one doesn't. So will need to carefully test it.

I expect anything we do here to be "special", which may indeed mean adjusting things in brew to allow depends_on "pkg-config" (potentially for a long time/forever as it would affect so many third-party formulae).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants