-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubetail 0.0.1 (new formula) #194879
base: master
Are you sure you want to change the base?
kubetail 0.0.1 (new formula) #194879
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
checkout #91754 |
#91754 is for a different kubetail |
@chenrui333 Thanks for the feedback! I'll work on this tomorrow. |
Sets the url of the kubetail formula to the cli/v0.0.1 stable release and also adds new test using `kubetail serve --test` flag which tests dashboard server startup and shutdown.
Adds error handling to kubetail formula for case where .kube/config is not present on users system.
Fixed typo with missing "end" in if/else block in kubetail test.
* Removed unnecessary 0 in `shell_output()` command * Used `$CHILD_STATUS.exitstatus.zero?` instead of `$CHILD_STATUS.exitstatus == 0`
All the CI tests are passing except for the commit style check. Can I fix this in the PR merge message? |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?