Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubetail 0.0.1 (new formula) #194879

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

amorey
Copy link

@amorey amorey commented Oct 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 18, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333
Copy link
Member

checkout #91754

@chenrui333 chenrui333 changed the title Adds kubetail formula kubetail 0.8.0-rc1 (new formula) Oct 18, 2024
@amorey
Copy link
Author

amorey commented Oct 18, 2024

#91754 is for a different kubetail

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue labels Oct 18, 2024
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
Formula/k/kubetail.rb Outdated Show resolved Hide resolved
@amorey
Copy link
Author

amorey commented Oct 18, 2024

@chenrui333 Thanks for the feedback! I'll work on this tomorrow.

Sets the url of the kubetail formula to the cli/v0.0.1 stable release and also adds new test using `kubetail serve --test` flag which tests dashboard server startup and shutdown.
Adds error handling to kubetail formula for case where .kube/config is not present on users system.
Fixed typo with missing "end" in if/else block in kubetail test.
@amorey amorey changed the title kubetail 0.8.0-rc1 (new formula) kubetail 0.0.1 (new formula) Oct 19, 2024
* Removed unnecessary 0 in `shell_output()` command
* Used `$CHILD_STATUS.exitstatus.zero?` instead of `$CHILD_STATUS.exitstatus == 0`
@amorey
Copy link
Author

amorey commented Oct 19, 2024

All the CI tests are passing except for the commit style check. Can I fix this in the PR merge message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants