-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typedb 2.29.1 #194822
base: master
Are you sure you want to change the base?
typedb 2.29.1 #194822
Conversation
The `typedb` formula hasn't been updated since 2.23.0, as upstream now splits release assets into arm64 and x86_64 archives (so `brew bump-formula-pr` produces a broken `url`). This updates to the latest version, 2.29.1, but it requires a somewhat ridiculous approach (the cask DSL has a more elegant way of handling some of this). Besides that, the license changed to MPL 2.0 in version 2.28.0.
on_arm do | ||
on_macos do | ||
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-mac-arm64-2.29.1.zip" | ||
sha256 "1270565acd7d5c61475831dac408f2069533ecf4ffee416ae474962ce1a71603" | ||
end | ||
on_linux do | ||
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-linux-arm64-2.29.1.tar.gz" | ||
sha256 "4846e0496c9d90542fe677bd44ec78fe31a056a07770b5b53703ea0c781e99d6" | ||
end | ||
end | ||
on_intel do | ||
on_macos do | ||
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-mac-x86_64-2.29.1.zip" | ||
sha256 "82ad962d3248d0a883d129a01b7593960031758283270128601a948be637854a" | ||
end | ||
on_linux do | ||
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-linux-x86_64-2.29.1.tar.gz" | ||
sha256 "4b358ee8beb76f856ca21c61979828f9e082f00591942bf770a1cb2aa53fe4bf" | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks suspicious TBH. Doesn't seem compatible with https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diffing the extracted files and running pkgdiff
on the differing jar files, there are currently two that contain OS/arch-specific dynamic libraries:
- console/lib/com-vaticle-typedb-typedb-driver-jni-(linux|macosx)-(arm64|x86_64)-2.29.0.jar
- server/lib/com-google-ortools-ortools-(darwin|linux)-(aarch64|x86-64)-9-6-2534.jar
The 2.23.0 release provides both the ARM and x86 ortools files and it doesn't contain the aforementioned driver-jni
file.
There are other jar files in server/lib (e.g., com-vaticle-typedb-typedb-core-common-2.29.1.jar) that differ only in META-INF/MANIFEST.MF
(e.g., Target-Label: //common:common-mac-arm64
vs. Target-Label: //common:common-linux-x86_64
). The 2.23.0 release omits the arch from the Target-Label
(e.g., common-mac
, common-linux
).
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?The
typedb
formula hasn't been updated since 2.23.0, as upstream now splits release assets into arm64 and x86_64 archives (sobrew bump-formula-pr
produces a brokenurl
). This updates to the latest version, 2.29.1, but it requires a somewhat ridiculous approach (the cask DSL has a more elegant way of handling some of this).The previous repository (vaticle/typedb) now redirects to typedb/typedb (and the vaticle organization says "Moved to: https://github.com/typedb"), so this updates the URL accordingly.
Besides that, the license changed to MPL 2.0 in version 2.28.0: https://github.com/typedb/typedb/blob/2.28.0/LICENSE