openjdk@8 1.8.0-432

[calvinit]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

[calvinit]

Why is the openjdk version used to test embulk here openjdk@21 instead of openjdk@8? Did the following check fail to work correctly?

on_arm do
  depends_on "openjdk@21"
end
on_intel do
  depends_on "openjdk@8"
end

I printed the content of the embulk script at bin/embulk on my Intel Mac, and it is as follows:

#!/bin/bash
export JAVA_HOME="${JAVA_HOME:-/usr/local/opt/openjdk@8/libexec/openjdk.jdk/Contents/Home}"
exec "${JAVA_HOME}/bin/java"  -jar "/usr/local/Cellar/embulk/0.11.5/libexec/embulk-0.11.5.jar" "$@"

It seems that the JAVA_HOME environment variable already has a value (which is /usr/local/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home), so the subsequent openjdk@8 environment variable value is not being applied. Alternatively, the value of java_version might actually be 21 (java_version = Hardware::CPU.intel? ? "1.8" : "21"). Could this be a bug in the test-bot or brew? Because when testing embulk individually, there is no problem, but here, when it is tested as a dependency of openjdk@8 1.8.0-432, the problem arises.

P.S. def install of embulk.rb:

def install
  java_version = Hardware::CPU.intel? ? "1.8" : "21"
  libexec.install "embulk-#{version}.jar"
  bin.write_jar_script libexec/"embulk-#{version}.jar", "embulk", java_version:
end