Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequoia-sq 0.38.0 (new formula) #194588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rrotter
Copy link
Contributor

@rrotter rrotter commented Oct 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

~ % brew audit --new sequoia-sq
sequoia-sq
  * GitLab repository not notable enough (<30 forks and <75 stars)
Error: 1 problem in 1 formula detected.

https://gitlab.com/sequoia-pgp/sequoia-sq does not have very many stars, but I'd ask that you consider:

  1. It's the main CLI for its library/parent project, https://gitlab.com/sequoia-pgp/sequoia, which has just under 400 stars
  2. It's in Debian, Arch, and Fedora: https://repology.org/project/sequoia-sq/badges

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Oct 16, 2024
@chenrui333 chenrui333 changed the title Sequoia sq sequoia-sq 0.38.0 (new formula) Oct 16, 2024
Formula/s/sq.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue autosquash Automatically squash pull request commits according to Homebrew style. labels Oct 17, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 17, 2024
@rrotter
Copy link
Contributor Author

rrotter commented Oct 17, 2024

Okay, there's clearly some issues to work out here. I'll try this in a Linux vm tomorrow evening. TBH I wrote this a while ago and really thought I'd tested on Linux too, but apparently I didn't. (Works fine on macOS, I wouldn't have sent the pr otherwise)

@rrotter rrotter marked this pull request as draft October 17, 2024 03:57
@chenrui333
Copy link
Member

Sounds good, thanks @rrotter!

@rrotter rrotter force-pushed the sequoia-sq branch 2 times, most recently from 17307ff to 56dc17a Compare October 19, 2024 00:21
@rrotter rrotter marked this pull request as ready for review October 19, 2024 00:41
@rrotter rrotter force-pushed the sequoia-sq branch 2 times, most recently from c4c9281 to 9f4bbd9 Compare October 19, 2024 00:55
@rrotter rrotter marked this pull request as draft October 19, 2024 01:54
@rrotter
Copy link
Contributor Author

rrotter commented Oct 19, 2024

Okay, I've fixed the build failures (and made brew linkage happy afaict). Now the only error I'm getting is the brew audit --new notability failure. Can you consider an exception considering the mitigating factors I listed above?

@rrotter rrotter marked this pull request as ready for review October 19, 2024 02:34
@bevanjkay bevanjkay added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants