-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AArch64 support #31
base: main
Are you sure you want to change the base?
Conversation
- container: debian7 | ||
- arch: x86_64 | ||
runs-on: ubuntu-latest | ||
# TODO: add aarch64 when available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'd rather we didn't add aarch64
in here until we have CI to test it (and same for Portable Ruby).
LGTM in general. I'm happy to either:
For Portable Ruby we have already have full arm64 support in the formulae (except adding the GitHub Actions arm64 support ETA is early 2025 (delayed from Q4 2024). |
Given the branch name, existing discussions, etc. of this PR, let me do the opposite: I split the architecture agnostic changes into #32. |
Is AArch64 == arm64 on Linux? If so: to avoid confusion: can we try to always call it the same thing 😅. |
Yes, they both refer to 64-bit ARM but AArch64 is more commonly used in Linux land ( |
@ZhongRuoyu Thanks for explaining! Thought this was adding Another Linux ARM 😁 |
Yeah we've yet to technically make aarch64 == arm64 in Homebrew/brew code. It just happens to work given most systems agree on the naming and we haven't needed to worry about compatibility of things between incompatible systems (macOS and Linux). |
This brings AArch64 support and allows us to build binaries for bootstrapping glibc on any AArch64 Linux system.
The newly added AArch64 image is based on
centos:7
as it ships glibc 2.17, the first glibc release to support AArch64 1.Changes split into #32
I've also bumped most of the tools to a newer version that builds without additional patches/hacks. Notably:
<stdatomic.h>
is needed but not provided by Debian Wheezy's host toolchain.The changes here have been tested on both architectures. The binaries built here can support building
glibc
2.35 incentos:7
on AArch64 Linux.Footnotes
https://sourceware.org/glibc/wiki/Release/2.17 ↩