Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mktemp: strict type and allow #run without chdir #18560

Merged
merged 2 commits into from
Oct 17, 2024
Merged

mktemp: strict type and allow #run without chdir #18560

merged 2 commits into from
Oct 17, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 13, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Was looking into #18548 and thought we could avoid some duplication by adjusting Mktemp.

In this case, the other PR would use

Mktemp.new("homebrew-unpack").run(chdir: false) do |tmp_unpack_dir|
  tmp_unpack_dir = T.must(tmp_unpack_dir.tmpdir)

This PR does restrict arguments for Mktemp so no longer an accept an arbitrary hash but instead takes in specific boolean parameters.

I think this is fine as it is a private API, but can restore opts if preferred.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @cho-m!

Library/Homebrew/formula.rb Outdated Show resolved Hide resolved
@cho-m cho-m merged commit 1fdbc6f into master Oct 17, 2024
33 checks passed
@cho-m cho-m deleted the mktemp-type branch October 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants