Don't hard-code runtime application path #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangfeld
changed the title
benlangfeld
force-pushed
the
feature/flexible-directory-structure
branch
5 times, most recently
from
939a2b0 to
e8d80fe
Compare
It is not guaranteed that the app is installed to /app. Users of buildpacks other than Heroku require applications to be stored at other paths, such as [pkgr](http://github.com/crohr/pkgr) which uses /opt/${APP_NAME}. Furthermore, the source may not be located at /app at compile time, since not every buildpack executor uses a layered filesystem, and so must resort to using a sandbox build directory (some call this the good old days). See crohr/pkgr#93 for the source of this.
benlangfeld
added a commit
to benlangfeld/QueueFlex
that referenced
this pull request
Jan 18, 2016
benlangfeld
changed the title
|
@benlangfeld I'll try this out this weekend and merge it if alright. |
|
@HashNuke Deployments to both Heroku and pkgr work just great with this change. Thanks for your attention on this. Note that I also have a relevant more general issue open. |
benlangfeld
force-pushed
the
feature/flexible-directory-structure
branch
from
2986ed6 to
e8d80fe
Compare
|
|
|
@HashNuke Any chance of a merge here? |
|
@benlangfeld Sorry about the delay. Merged. Thank you very much ~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not guaranteed that the app is installed to /app. Users of buildpacks other than Heroku require applications to be stored at other paths, such as pkgr which uses /opt/${APP_NAME}. Furthermore, the source may not be located at /app at compile time, since not every buildpack executor uses a layered filesystem, and so must resort to using a sandbox build directory (some call this the good old days).
This seems to have been broken by f651aac.
See crohr/pkgr#93 for the source of this.