@trexfeathers contributions to SciTools/iris#5740. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
commented
Feb 19, 2024
Comment on lines
+480
to
+483
| Below is an example of using GeoVista to plot a low-res | ||
| sample :attr:`~iris.cube.Cube.mesh` based :class:`~iris.cube.Cube`. For | ||
| some truly spectacular visualisations of high-res data please see the | ||
| GeoVista :external+geovista:doc:`generated/gallery/index`. |
There was a problem hiding this comment.
I have:
- Removed the example of plotting a very simple mesh
- Changed the global example to use a mesh that is more readily available to the docs builder and to users.
I originally hoped to make this a running example, rather than a static one, which necessitated the big changes. However @bjlittle tells me that is non-trivial where PyVista is concerned. I have still kept most of those changes since it is now easier for a user to replicate, and will be easier for us to iterate in future.
trexfeathers
commented
Feb 19, 2024
Comment on lines
585
to
587
| An Iris convenience for regional extraction is also provided: | ||
| :func:`iris.experimental.geovista.region_extraction`; demonstrated | ||
| below: |
There was a problem hiding this comment.
The functions we have written in #SciTools#5740 have made this example much simpler.
trexfeathers
commented
Feb 19, 2024
lib/iris/experimental/geovista.py
Outdated
HGWright
approved these changes
Mar 27, 2024
|
Thanks @trexfeathers for this. Great work especially on the docstrings! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iris.experimental.geovistaClick here for the rendered documentation